Skip to content

Fix PHPUnit Risky Tests #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fix PHPUnit Risky Tests #449

merged 1 commit into from
Jul 24, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 24, 2019

Some tests were missing assert

Screen Shot 2019-07-23 at 4 16 52 PM

Some tests were missing assert
@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #449 into master will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             master   #449      +/-   ##
==========================================
+ Coverage     96.98%    98%   +1.01%     
  Complexity     1058   1058              
==========================================
  Files            39     39              
  Lines          2950   2950              
==========================================
+ Hits           2861   2891      +30     
+ Misses           89     59      -30
Impacted Files Coverage Δ Complexity Δ
src/Parse/ParseObject.php 98.1% <0%> (+0.17%) 224% <0%> (ø) ⬇️
src/Parse/ParseUser.php 98.31% <0%> (+1.26%) 67% <0%> (ø) ⬇️
src/Parse/Internal/ParseRelationOperation.php 100% <0%> (+1.66%) 43% <0%> (ø) ⬇️
src/Parse/ParseClient.php 95.59% <0%> (+2.64%) 97% <0%> (ø) ⬇️
src/Parse/ParseACL.php 100% <0%> (+5.83%) 61% <0%> (ø) ⬇️
src/Parse/ParseSessionStorage.php 100% <0%> (+9.09%) 11% <0%> (ø) ⬇️
src/Parse/ParseMemoryStorage.php 100% <0%> (+12.5%) 8% <0%> (ø) ⬇️
src/Parse/ParsePush.php 100% <0%> (+14.28%) 13% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 942dcc2...33c6ca5. Read the comment docs.

@dplewis dplewis merged commit 96ccc6d into master Jul 24, 2019
@dplewis dplewis deleted the risky-test branch July 24, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants